Open
Conversation
ErikSchierboom
approved these changes
Aug 13, 2024
Contributor
|
Perhaps |
IsaacG
reviewed
Aug 13, 2024
| - "9142" | ||
|
|
||
| And if you ask for a 6-digit series from a 5-digit string, you deserve whatever you get. | ||
| Trying to extract a 6-digit series from a 5-digit string should result in an error. |
Member
There was a problem hiding this comment.
Is "should result in an error" something that should be track specific behavior?
Member
|
Old PR. Should we move it forward? Simply by looking at the canonical data, it appears that there are even more cases where an error is expected:
So, it's best to either mention all cases explicitly or remove any reference to errors from the description altogether, which seems more reasonable to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not set on the wording, or which cases we should cover, but putting this here so it can be riffed on by maintainers.
Forum discussion: http://forum.exercism.org/t/series-problem-description-unclear/12477